[SPARK-24930][SQL] Improve exception information when using LOAD DATA LOCAL INPATH

[ouyangxiaochen]

What changes were proposed in this pull request?

1. root user create a test.txt file contains a record '123' in /root/ directory
2. switch mr user to execute spark-shell --master local

scala> spark.version
res2: String = 2.2.1

scala> spark.sql("create table t1(id int) partitioned by(area string)");
2018-07-26 17:20:37,523 WARN org.apache.hadoop.hive.metastore.HiveMetaStore: Location: hdfs://nameservice/spark/t1 specified for non-external table:t1
res4: org.apache.spark.sql.DataFrame = []

scala> spark.sql("load data local inpath '/root/test.txt' into table t1 partition(area ='025')")
org.apache.spark.sql.AnalysisException: LOAD DATA input path does not exist: /root/test.txt;
 at org.apache.spark.sql.execution.command.LoadDataCommand.run(tables.scala:339)
 at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:58)
 at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:56)
 at org.apache.spark.sql.execution.command.ExecutedCommandExec.executeCollect(commands.scala:67)
 at org.apache.spark.sql.Dataset.<init>(Dataset.scala:183)
 at org.apache.spark.sql.Dataset$.ofRows(Dataset.scala:68)
 at org.apache.spark.sql.SparkSession.sql(SparkSession.scala:639)
 ... 48 elided

scala>

In fact, the input path exists, but the mr user does not have permission to access the directory /root/ ,so the message throwed by AnalysisException can confuse user.

How was this patch tested?

existing test case

Please review http://spark.apache.org/contributing.html before opening a pull request.

[gatorsmile]

ok to test

[SparkQA]

Test build #93622 has finished for PR 21881 at commit 0eb648c.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[xuanyuanking]

LGTM, just nits about exception msg.

[xuanyuanking]

Nit: no need to print the $path twice.

[ouyangxiaochen]

OK, Thanks!

[gatorsmile]

Test case?

[ouyangxiaochen]

@gatorsmile Hi, i am not sure how to build this scene in test case, just assert whether the exception info contains the key message have no permission to access the input path or not?

[AmplabJenkins]

Can one of the admins verify this patch?

[github-actions]

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!