-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24956][Build][test-maven] Upgrade maven version to 3.5.4 #21905
Conversation
hmm, interesting suggestions #21905 (comment) |
Test build #93711 has finished for PR 21905 at commit
|
retest this please |
Test build #93718 has finished for PR 21905 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine ... I haven't had problems with Maven 3.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh darnit, as soon as I merge this (which is fine) it triggers me to think -- this should also have updated the version of Maven that the build script downloads for you. I'll do that. EDIT: nope the build script reads it from the POM now. Smart! |
What changes were proposed in this pull request?
This PR updates maven version from 3.3.9 to 3.5.4. The current build process uses mvn 3.3.9 that was release on 2015, which looks pretty old.
We met an issue to need the maven 3.5.2 or later.
The release note of the 3.5.4 is here. Note version 3.4 was skipped.
From the release note of the 3.5.0, the followings are new features:
How was this patch tested?
Existing tests