Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24956][Build][test-maven] Upgrade maven version to 3.5.4 #21905

Closed
wants to merge 1 commit into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented Jul 28, 2018

What changes were proposed in this pull request?

This PR updates maven version from 3.3.9 to 3.5.4. The current build process uses mvn 3.3.9 that was release on 2015, which looks pretty old.
We met an issue to need the maven 3.5.2 or later.

The release note of the 3.5.4 is here. Note version 3.4 was skipped.

From the release note of the 3.5.0, the followings are new features:

  1. ANSI color logging for improved output visibility
  2. add support for module name != artifactId in every calculated URLs (project, SCM, site): special project.directory property
  3. create a slf4j-simple provider extension that supports level color rendering
  4. ModelResolver interface enhancement: addition of resolveModel(Dependency) supporting version ranges

How was this patch tested?

Existing tests

@holdensmagicalunicorn
Copy link

@kiszk, thanks! I am a bot who has found some folks who might be able to help with the review:@tomdz, @pwendell and @marmbrus

@kiszk
Copy link
Member Author

kiszk commented Jul 28, 2018

cc @srowen @HyukjinKwon

@felixcheung
Copy link
Member

hmm, interesting suggestions #21905 (comment)

@SparkQA
Copy link

SparkQA commented Jul 28, 2018

Test build #93711 has finished for PR 21905 at commit a8a545c.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jul 28, 2018

Test build #93718 has finished for PR 21905 at commit a8a545c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine ... I haven't had problems with Maven 3.5.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srowen
Copy link
Member

srowen commented Jul 29, 2018

Oh darnit, as soon as I merge this (which is fine) it triggers me to think -- this should also have updated the version of Maven that the build script downloads for you. I'll do that. EDIT: nope the build script reads it from the POM now. Smart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants