[SPARK-23698] Define xrange() for Python 3 in dumpdata_script.py #21959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__xrange()__ was removed in Python 3 in favor of __range()__. This simple change removes three Undefined Names was originally suggested in apache#20838 which is currently mired in 50+ comments on unrelated modifications. @HyukjinKwon @holdenk
|
@cclauss, thanks! I am a bot who has found some folks who might be able to help with the review:@pwendell and @HyukjinKwon |
|
Can one of the admins verify this patch? |
|
I think you can push the changes in #20838 and close this one. They look virtually the same issue. |
|
As it says in the commit message, these changes are already in #20838 but that PR has been open for 139 days and has 50+ comments. The only way that I seem to make progress is by opening separate PRs that are easier to review and approve. |
|
I am going to review and merge that one soon. It doesn't need to open multiple PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xrange() was removed in Python 3 in favor of range(). This simple change resolves three Undefined Names was originally suggested in #20838 which is currently mired in 50+ comments on unrelated modifications. @HyukjinKwon @holdenk
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.