[FOLLOW-UP][SPARK-23772][SQL] Provide an option to ignore column of all null values or empty array during JSON schema inference #22002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maropu Please, have a look at the PR. |
|
Test build #94249 has finished for PR 22002 at commit
|
|
Test build #94250 has finished for PR 22002 at commit
|
|
jenkins, retest this, please |
|
Test build #94253 has finished for PR 22002 at commit
|
maropu
reviewed
Aug 6, 2018
| @@ -267,7 +267,7 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None, | |||
| mode=mode, columnNameOfCorruptRecord=columnNameOfCorruptRecord, dateFormat=dateFormat, | |||
| timestampFormat=timestampFormat, multiLine=multiLine, | |||
| allowUnquotedControlChars=allowUnquotedControlChars, lineSep=lineSep, | |||
| samplingRatio=samplingRatio, encoding=encoding) | |||
| samplingRatio=samplingRatio, dropFieldIfAllNull=dropFieldIfAllNull, encoding=encoding) | |||
|
LGTM cc: @HyukjinKwon |
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
dropFieldIfAllNullparameter of thejsonmethod wasn't set as an option. This PR fixes that.How was this patch tested?
I added a test to
sql/test.py