Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-25043: print master and appId from spark-sql on startup #22025

Conversation

abellina
Copy link
Contributor

@abellina abellina commented Aug 7, 2018

What changes were proposed in this pull request?

A small change to print the master and appId from spark-sql as with logging turned down all the way (log4j.logger.org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver=WARN), we may not know this information easily. This adds the following string before the spark-sql> prompt shows on the screen.

Spark master: yarn, Application Id: application_123456789_12345

How was this patch tested?

I ran spark-sql locally and saw the appId displayed as expected.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@tgravescs
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Aug 8, 2018

Test build #94442 has finished for PR 22025 at commit 42c510c.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 9, 2018

Test build #94497 has finished for PR 22025 at commit c651373.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

+1

@HyukjinKwon
Copy link
Member

@abellina, how is the output like? mind if I ask put it in the PR description just to make the review easier if that's not hard?

@abellina
Copy link
Contributor Author

@HyukjinKwon I have updated the description. Thanks for the comment.

@tgravescs
Copy link
Contributor

merged to master, thanks @abellina

@asfgit asfgit closed this in b81e303 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants