[SPARK-25093][SQL] Avoid recompiling regexp for comments multiple times #22135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM, but is it worth to address the similar issues at once? |
|
Test build #94897 has finished for PR 22135 at commit
|
|
thanks for the comment @kiszk , I am doing it! |
|
Test build #94926 has finished for PR 22135 at commit
|
igreenfield
reviewed
Aug 19, 2018
| ("""([ |\t]*?\/\*[\s|\S]*?\*\/[ |\t]*?)|""" + // strip /*comment*/ | ||
| """([ |\t]*?\/\/[\s\S]*?\n)""").r // strip //comment | ||
| val codeWithoutComment = commentReg.replaceAllIn(input, "") | ||
| val codeWithoutComment = commentRegexp.replaceAllIn(input, "") | ||
| codeWithoutComment.replaceAll("""\n\s*\n""", "\n") // strip ExtraNewLines |
There was a problem hiding this comment.
this line also compile regex and could be replaced!
igreenfield
reviewed
Aug 19, 2018
|
Test build #95017 has finished for PR 22135 at commit
|
|
retest this please |
|
Test build #95038 has finished for PR 22135 at commit
|
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR moves the compilation of the regexp for code formatting outside the method which is called for each code block when splitting expressions, in order to avoid recompiling the regexp every time.
Credit should be given to Izek Greenfield.
How was this patch tested?
existing UTs