[SPARK-25223][SQL] Use a map to store values for NamedLambdaVariable. #22216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
|
Test build #95203 has finished for PR 22216 at commit
|
cloud-fan
reviewed
Aug 24, 2018
| object NamedLambdaVariable { | ||
|
|
||
| private[this] val _values = | ||
| new ThreadLocal[mutable.Map[NamedLambdaVariable, Any]] { |
There was a problem hiding this comment.
shall we use ExprId as the key?
|
I think the use of global state and a thread local is far more hacky and probably is slower. The only clean solution I see here is to pass the lambda values around using the input row. I am not saying that this easy. |
|
I see. Let me think again. I'd close this for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently we use
functionsForEval,NamedLambdaVaribles in which are replace with of arguments from the original functions, to make sure the lambda variables refer the same instances as of arguments, but it's pretty hacky.Instead, we can use a global map and set/get the lambda variable values in the map.
How was this patch tested?
Existing tests.