[SPARK-25266][CORE] Fix memory leak in Barrier Execution Mode #22258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remove vulnerability from the title? Otherwise it sounds like a security vulnerability here. |
|
Test build #95372 has finished for PR 22258 at commit
|
sarutak
changed the title
sarutak
changed the title
|
All right. It's done. |
sarutak
changed the title
|
retest this please. |
|
LGTM pending test |
|
Test build #95396 has finished for PR 22258 at commit
|
|
Merged into master. Thanks! |
fjh100456
pushed a commit
to fjh100456/spark
that referenced
this pull request
Aug 31, 2018
## What changes were proposed in this pull request? BarrierCoordinator uses Timer and TimerTask. `TimerTask#cancel()` is invoked in ContextBarrierState#cancelTimerTask but `Timer#purge()` is never invoked. Once a TimerTask is scheduled, the reference to it is not released until `Timer#purge()` is invoked even though `TimerTask#cancel()` is invoked. ## How was this patch tested? I checked the number of instances related to the TimerTask using jmap. Closes apache#22258 from sarutak/fix-barrierexec-oom. Authored-by: sarutak <sarutak@oss.nttdata.co.jp> Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BarrierCoordinator uses Timer and TimerTask.
TimerTask#cancel()is invoked in ContextBarrierState#cancelTimerTask butTimer#purge()is never invoked.Once a TimerTask is scheduled, the reference to it is not released until
Timer#purge()is invoked even thoughTimerTask#cancel()is invoked.How was this patch tested?
I checked the number of instances related to the TimerTask using jmap.