[SPARK-25431][SQL][EXAMPLES] Fix function examples and unify the format of the example results. #22421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #96069 has finished for PR 22421 at commit
|
gatorsmile
reviewed
Sep 14, 2018
asfgit
pushed a commit
that referenced
this pull request
Sep 14, 2018
…at of the example results. ## What changes were proposed in this pull request? There are some mistakes in examples of newly added functions. Also the format of the example results are not unified. We should fix and unify them. ## How was this patch tested? Manually executed the examples. Closes #22421 from ueshin/issues/SPARK-25431/fix_examples. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com> (cherry picked from commit 9c25d7f) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
| @@ -131,7 +131,7 @@ case class Size(child: Expression) extends UnaryExpression with ExpectsInputType | |||
| examples = """ | |||
| Examples: | |||
| > SELECT _FUNC_(map(1, 'a', 2, 'b')); | |||
| [1,2] | |||
| [1, 2] | |||
|
@ueshin and @gatorsmile . Sorry, but could you explain where did you get the new result? IIRC, historically, the example illustrates the result from spark-sql> describe function extended map_concat;
Function: map_concat
Class: org.apache.spark.sql.catalyst.expressions.MapConcat
Usage: map_concat(map, ...) - Returns the union of all the given maps
Extended Usage:
Examples:
> SELECT map_concat(map(1, 'a', 2, 'b'), map(2, 'c', 3, 'd'));
[1 -> "a", 2 -> "b", 2 -> "c", 3 -> "d"]
Since: 2.4.0
spark-sql> SELECT map_concat(map(1, 'a', 2, 'b'), map(2, 'c', 3, 'd'));
{1:"a",2:"c",3:"d"}
Time taken: 0.034 seconds, Fetched 1 row(s) |
|
If you don't mind, please revert this. |
| @@ -718,7 +718,7 @@ case class MapConcat(children: Seq[Expression]) extends ComplexTypeMergingExpres | |||
| examples = """ | |||
| Examples: | |||
| > SELECT _FUNC_(array(struct(1, 'a'), struct(2, 'b'))); | |||
| {1:"a",2:"b"} | |||
| [1 -> "a", 2 -> "b"] | |||
There was a problem hiding this comment.
The previous one is correct.
spark-sql> SELECT map_from_entries(array(struct(1, 'a'), struct(2, 'b')));
{1:"a",2:"b"}
|
@dongjoon-hyun I picked the string from |
|
@ueshin . Could you revert the current one and send a new one please? |
|
@dongjoon-hyun Sure, reverted. Thanks! |
|
Thank you, @ueshin . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are some mistakes in examples of newly added functions. Also the format of the example results are not unified. We should fix and unify them.
How was this patch tested?
Manually executed the examples.