Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-25487][SQL][TEST] Refactor PrimitiveArrayBenchmark #22497

Closed
wants to merge 1 commit into from

Conversation

seancxmao
Copy link
Contributor

What changes were proposed in this pull request?

Refactor PrimitiveArrayBenchmark to use main method and print the output as a separate file.

Run blow command to generate benchmark results:

SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.PrimitiveArrayBenchmark"

How was this patch tested?

Manual tests.

@wangyum
Copy link
Member

wangyum commented Sep 20, 2018

LGTM

@SparkQA
Copy link

SparkQA commented Sep 20, 2018

Test build #96365 has finished for PR 22497 at commit 631df4b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Sep 21, 2018

LGTM

@asfgit asfgit closed this in 1f4ca6f Sep 21, 2018
@kiszk
Copy link
Member

kiszk commented Sep 21, 2018

Thanks! merging to master.

@wangyum
Copy link
Member

wangyum commented Sep 21, 2018

Congratulation, @kiszk

@seancxmao
Copy link
Contributor Author

@kiszk @wangyum Thank you!

@gengliangwang
Copy link
Member

Congratulation, @kiszk

I am working on #22513 . If it is possible, could you wait until we reach an agreement in that PR before merging other benchmark?
In this PR, there is also such problem:

import org.apache.spark.util.{Benchmark, BenchmarkBase => FileBenchmarkBase}

@kiszk
Copy link
Member

kiszk commented Sep 21, 2018

I see. I will wait in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants