[SPARK-25502][CORE][WEBUI]Empty Page when page number exceeds the reatinedTask size. #22526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahidki31
force-pushed
the
SPARK-25502
branch
from
6204cbe
to
af8ff45
Compare
shahidki31
changed the title
|
cc @vanzin |
shahidki31
force-pushed
the
SPARK-25502
branch
from
af8ff45
to
8309722
Compare
srowen
reviewed
Sep 23, 2018
| override def dataSize: Int = { | ||
| val storedTasks = store.taskCount(stage.stageId, stage.attemptId).toInt | ||
| val totalTasks = taskCount(stage) | ||
| if (totalTasks > storedTasks) { |
There was a problem hiding this comment.
Just write math.min(storedTasks, totalTasks)
There was a problem hiding this comment.
Yes. totalTasks will be always greater than or equal to storedTasks. We can simply return storedTasks. But for better understanding I have put it in the if else condition.
I have modified the code based on your suggestion.
There was a problem hiding this comment.
Oh, hm I would have thought it's simpler to return the single value that this always takes on.
There was a problem hiding this comment.
Thanks. I have updated the PR by returning only storedTasks. Kindly look into the updated code.
shahidki31
force-pushed
the
SPARK-25502
branch
from
8309722
to
8e7f87f
Compare
shahidki31
changed the title
srowen
approved these changes
Sep 24, 2018
shahidki31
force-pushed
the
SPARK-25502
branch
from
8e7f87f
to
4f37ca8
Compare
|
Test build #4349 has started for PR 22526 at commit |
srowen
reviewed
Sep 24, 2018
| @@ -685,7 +685,10 @@ private[ui] class TaskDataSource( | |||
|
|
|||
| private var _tasksToShow: Seq[TaskData] = null | |||
|
|
|||
| override def dataSize: Int = taskCount(stage) | |||
| override def dataSize: Int = { | |||
| val storedTasks = store.taskCount(stage.stageId, stage.attemptId).toInt | |||
There was a problem hiding this comment.
You don't need the intermediate variable here.
shahidki31
force-pushed
the
SPARK-25502
branch
from
4f37ca8
to
4444fa4
Compare
jiangxb1987
reviewed
Sep 24, 2018
| @@ -685,7 +685,7 @@ private[ui] class TaskDataSource( | |||
|
|
|||
| private var _tasksToShow: Seq[TaskData] = null | |||
|
|
|||
| override def dataSize: Int = taskCount(stage) | |||
| override def dataSize: Int = store.taskCount(stage.stageId, stage.attemptId).toInt | |||
There was a problem hiding this comment.
nit: after this change, the function taskCount() is only referenced by totalTasks, we can inline that.
shahidki31
force-pushed
the
SPARK-25502
branch
from
9a33c34
to
ca8d4f2
Compare
srowen
approved these changes
Sep 24, 2018
|
Merging to master / 2.4 / 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Sep 24, 2018
…atinedTask size. ## What changes were proposed in this pull request? Test steps : 1) bin/spark-shell --conf spark.ui.retainedTasks=200 ``` val rdd = sc.parallelize(1 to 1000, 1000) rdd.count ``` Stage tab in the UI will display 10 pages with 100 tasks per page. But number of retained tasks is only 200. So, from the 3rd page onwards will display nothing. We have to calculate total pages based on the number of tasks need display in the UI. **Before fix:**  **After fix:**  ## How was this patch tested? Manually tested Closes #22526 from shahidki31/SPARK-25502. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit 3ce2e00) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
asfgit
pushed a commit
that referenced
this pull request
Sep 24, 2018
…atinedTask size. ## What changes were proposed in this pull request? Test steps : 1) bin/spark-shell --conf spark.ui.retainedTasks=200 ``` val rdd = sc.parallelize(1 to 1000, 1000) rdd.count ``` Stage tab in the UI will display 10 pages with 100 tasks per page. But number of retained tasks is only 200. So, from the 3rd page onwards will display nothing. We have to calculate total pages based on the number of tasks need display in the UI. **Before fix:**  **After fix:**  ## How was this patch tested? Manually tested Closes #22526 from shahidki31/SPARK-25502. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit 3ce2e00) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
daspalrahul
pushed a commit
to daspalrahul/spark
that referenced
this pull request
Sep 29, 2018
…atinedTask size. ## What changes were proposed in this pull request? Test steps : 1) bin/spark-shell --conf spark.ui.retainedTasks=200 ``` val rdd = sc.parallelize(1 to 1000, 1000) rdd.count ``` Stage tab in the UI will display 10 pages with 100 tasks per page. But number of retained tasks is only 200. So, from the 3rd page onwards will display nothing. We have to calculate total pages based on the number of tasks need display in the UI. **Before fix:**  **After fix:**  ## How was this patch tested? Manually tested Closes apache#22526 from shahidki31/SPARK-25502. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test steps :
Stage tab in the UI will display 10 pages with 100 tasks per page. But number of retained tasks is only 200. So, from the 3rd page onwards will display nothing.
We have to calculate total pages based on the number of tasks need display in the UI.
Before fix:
After fix:
How was this patch tested?
Manually tested