Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-25606][TEST] Reduce DateExpressionsSuite test time costs in Jenkins #22632

Closed
wants to merge 1 commit into from
Closed

Conversation

wangyum
Copy link
Member

@wangyum wangyum commented Oct 4, 2018

What changes were proposed in this pull request?

Reduce DateExpressionsSuite.Hour test time costs in Jenkins by reduce iteration times.

How was this patch tested?

Manual tests on my local machine.
before:

- Hour (34 seconds, 54 milliseconds)

after:

- Hour (2 seconds, 697 milliseconds)

@wangyum wangyum changed the title [SPARK-25606][TESTS] Reduce DateExpressionsSuite test time costs in Jenkins [SPARK-25606][TEST] Reduce DateExpressionsSuite test time costs in Jenkins Oct 4, 2018
@SparkQA
Copy link

SparkQA commented Oct 4, 2018

Test build #96946 has finished for PR 22632 at commit 3256100.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented Oct 4, 2018

cc @gatorsmile @dongjoon-hyun

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged to master.

@asfgit asfgit closed this in f27d96b Oct 5, 2018
@wangyum
Copy link
Member Author

wangyum commented Oct 6, 2018

@gatorsmile I have some confusion. Is this

(0 to 5 * 24).foreach { i =>
c.add(Calendar.HOUR_OF_DAY, 1)
checkEvaluation(Quarter(Literal(new Date(c.getTimeInMillis))),
c.get(Calendar.MONTH) / 3 + 1)
}

should be

(0 to 24).foreach { h =>
  c.add(Calendar.HOUR_OF_DAY, h)
  checkEvaluation(Quarter(Literal(new Date(c.getTimeInMillis))),
    c.get(Calendar.MONTH) / 3 + 1)
}

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…nkins

## What changes were proposed in this pull request?

Reduce `DateExpressionsSuite.Hour` test time costs in Jenkins by reduce iteration times.

## How was this patch tested?
Manual tests on my local machine.
before:
```
- Hour (34 seconds, 54 milliseconds)
```
after:
```
- Hour (2 seconds, 697 milliseconds)
```

Closes apache#22632 from wangyum/SPARK-25606.

Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants