Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-25720][WEBUI] Support auto refresh page for the WEBUI #22714

Closed
wants to merge 1 commit into from

Conversation

shahidki31
Copy link
Contributor

What changes were proposed in this pull request?

Currently spark webui doesn't have an option of auto refresh page. Because of this, user has to reload
every time to see the updates in the page.

For SQL page and Streaming page, currently we are passing the refresh interval, but it is not implemented in the 'headerSparkPage' method. This PR, added the refresh functionality to the webui.

screenshot from 2018-10-13 23-18-06
screenshot from 2018-10-13 23-17-51
screenshot from 2018-10-13 23-17-40

How was this patch tested?

Manually verified.
Every 5 seconds the SQL page is refreshing.

screenshot from 2018-10-13 23-23-41

screenshot from 2018-10-13 23-24-27

@shahidki31
Copy link
Contributor Author

cc @srowen @cloud-fan . Kindly review.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Oct 13, 2018

Shouldn't it go in commonHeaderNodes?

Looks like this was added waaay back in JoshRosen@6aa08c3 by @tdas but never used. Only a few call sites set it. The problem I can see is that those hard-code it to 5 second refreshes.

I think we'd have to introduce a new parameter to control this, like spark.ui.refreshInterval or something, and then stop passing it into this method and just read it in this code somewhere?

@shahidki31
Copy link
Contributor Author

Thank you @srowen for the comment. Yes, we should not hard-code the refresh interval and we let the user to enable the parameter. I will update the code accordingly.

@felixcheung
Copy link
Member

can this be passed in as a param in the url?

@gengliangwang
Copy link
Member

BTW there is another approach: #21512

@shahidki31
Copy link
Contributor Author

shahidki31 commented Oct 14, 2018

@gengliangwang Sorry, I didn't see the PR before opening this PR. Yes, that PR also for auto refreshing the webui.

I have taken the patch and checked the functionality, and it seems fine. Below is the screen shot of the ui.
Except the alignment of the tabs, functionality seems good.

After the patch
screenshot from 2018-10-14 23-48-40

Before the patch
screenshot from 2018-10-13 23-23-41

@shahidki31
Copy link
Contributor Author

I am closing the PR, since already one PR is there for the webui auto refresh. Thanks.

@shahidki31 shahidki31 closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants