[MINOR][SQL] Avoid hardcoded configuration keys in SQLConf's doc
#22877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #98209 has finished for PR 22877 at commit
|
dongjoon-hyun
approved these changes
Oct 29, 2018
kiszk
reviewed
Oct 29, 2018
| @@ -408,15 +408,16 @@ object SQLConf { | |||
|
|
|||
| val PARQUET_FILTER_PUSHDOWN_DATE_ENABLED = buildConf("spark.sql.parquet.filterPushdown.date") | |||
| .doc("If true, enables Parquet filter push-down optimization for Date. " + | |||
| "This configuration only has an effect when 'spark.sql.parquet.filterPushdown' is enabled.") | |||
| s"This configuration only has an effect when '${PARQUET_FILTER_PUSHDOWN_ENABLED.key}' is " + | |||
There was a problem hiding this comment.
nit: Can we apply the same policy to other places, too?
'spark.sql.optimizer.planChangeLog.level' at L182
spark.sql.parquet.compression.codec at L397
spark.sql.orc.compression.codec at L493
There was a problem hiding this comment.
Hi, @kiszk . Those instances are impossible. We cannot use the value during defining the configuration.
|
Test build #98214 has finished for PR 22877 at commit
|
|
Merged to master |
|
Thanks, @kiszk and @dongjoon-hyun |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR proposes to avoid hardcorded configuration keys in SQLConf's `doc. ## How was this patch tested? Manually verified. Closes apache#22877 from HyukjinKwon/minor-conf-name. Authored-by: hyukjinkwon <gurwls223@apache.org> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to avoid hardcorded configuration keys in SQLConf's `doc.
How was this patch tested?
Manually verified.