[SPARK-25895][Core]Adding testcase to compare Lz4 and Zstd compression #22906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I don't think this tests something about the correctness of Spark though. I am not sure this is worth it. |
wangyum
reviewed
Oct 31, 2018
| @@ -128,6 +130,69 @@ class CompressionCodecSuite extends SparkFunSuite { | |||
| } | |||
| } | |||
|
|
|||
| test("SPARK-25895 Zstd shuffle Read/Write/spill comparison w.r.t lz4") { | |||
There was a problem hiding this comment.
How about add a benchmark? You can check our all benchmarks here:: https://issues.apache.org/jira/browse/SPARK-25475
There was a problem hiding this comment.
Thanks for your suggestion, i will go through the benchmarks and update the PR
|
Benchmarks aren't run with tests right? That's fine. I am still not sure Spark is the best place for this. |
|
Ping @Udbhav30 |
|
Okay I'll close this PR |
|
It was tested in Trino, please see: trinodb/trino#20274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a UT to verify Zstd compression algorithm has better compression ratio than lz4 in shuffle read/write and spill
How was this patch tested?
Added UT