Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-25913][SQL] Extend UnaryExecNode by unary SparkPlan nodes #22925

Closed
wants to merge 3 commits into from
Closed

[SPARK-25913][SQL] Extend UnaryExecNode by unary SparkPlan nodes #22925

wants to merge 3 commits into from

Conversation

MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Nov 1, 2018

What changes were proposed in this pull request?

In the PR, I propose to extend UnaryExecNode instead of SparkPlan by unary nodes.

@MaxGekk
Copy link
Member Author

MaxGekk commented Nov 1, 2018

ping @hvanhovell

@hvanhovell
Copy link
Contributor

LGTM

@MaxGekk
Copy link
Member Author

MaxGekk commented Nov 1, 2018

Need to check this:

spark/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/WriteToContinuousDataSourceExec.scala

Line 34 in 77e5244

case class WriteToContinuousDataSourceExec(writeSupport: StreamingWriteSupport, query: SparkPlan)

@SparkQA
Copy link

SparkQA commented Nov 1, 2018

Test build #98367 has finished for PR 22925 at commit 9a81bd2.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class ContinuousCoalesceExec(numPartitions: Int, child: SparkPlan) extends UnaryExecNode

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Test build #98402 has finished for PR 22925 at commit 0172030.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

gatorsmile
gatorsmile reviewed Nov 5, 2018
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks! Merged to master.

@asfgit asfgit closed this in 950e737 Nov 5, 2018
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
@MaxGekk @jackylee-ch
[SPARK-25913][SQL] Extend UnaryExecNode by unary SparkPlan nodes
1567d55 
## What changes were proposed in this pull request?

In the PR, I propose to extend `UnaryExecNode` instead of `SparkPlan` by unary nodes.

Closes apache#22925 from MaxGekk/unary-exec-node.

Authored-by: Maxim Gekk <max.gekk@gmail.com>
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
@MaxGekk MaxGekk deleted the unary-exec-node branch August 17, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatorsmile gatorsmile gatorsmile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@MaxGekk @hvanhovell @SparkQA @gatorsmile