Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-25926][CORE] Move config entries in core module to internal.config. #22928

Closed

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Nov 2, 2018

What changes were proposed in this pull request?

Currently definitions of config entries in core module are in several files separately. We should move them into internal/config to be easy to manage.

How was this patch tested?

Existing tests.

@ueshin
Copy link
Member Author

ueshin commented Nov 2, 2018

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Test build #98388 has finished for PR 22928 at commit 6537102.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Test build #98389 has finished for PR 22928 at commit e081cb2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Test build #98390 has finished for PR 22928 at commit 9d89b0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Nov 2, 2018

I don't like stashing everything in package.scala; I'm ok-ish with moving them under the internal.config package, but it would be better to keep them in separate source files.

@gatorsmile
Copy link
Member

Keeping them in separate source files is also fine to me. I think we should put them in the same package.

@SparkQA
Copy link

SparkQA commented Nov 5, 2018

Test build #98459 has finished for PR 22928 at commit 6144e01.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member Author

ueshin commented Nov 5, 2018

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Nov 5, 2018

Test build #98463 has finished for PR 22928 at commit 6144e01.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM

@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Nov 5, 2018

Test build #98471 has finished for PR 22928 at commit 6144e01.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@asfgit asfgit closed this in 78fa1be Nov 6, 2018
@cloud-fan
Copy link
Contributor

thanks, merging to master!

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…nfig.

## What changes were proposed in this pull request?

Currently definitions of config entries in `core` module are in several files separately. We should move them into `internal/config` to be easy to manage.

## How was this patch tested?

Existing tests.

Closes apache#22928 from ueshin/issues/SPARK-25926/single_config_file.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants