-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-25926][CORE] Move config entries in core module to internal.config. #22928
[SPARK-25926][CORE] Move config entries in core module to internal.config. #22928
Conversation
Test build #98388 has finished for PR 22928 at commit
|
Test build #98389 has finished for PR 22928 at commit
|
Test build #98390 has finished for PR 22928 at commit
|
I don't like stashing everything in |
Keeping them in separate source files is also fine to me. I think we should put them in the same package. |
Test build #98459 has finished for PR 22928 at commit
|
Jenkins, retest this please. |
Test build #98463 has finished for PR 22928 at commit
|
LGTM |
retest this please |
Test build #98471 has finished for PR 22928 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
thanks, merging to master! |
…nfig. ## What changes were proposed in this pull request? Currently definitions of config entries in `core` module are in several files separately. We should move them into `internal/config` to be easy to manage. ## How was this patch tested? Existing tests. Closes apache#22928 from ueshin/issues/SPARK-25926/single_config_file. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
What changes were proposed in this pull request?
Currently definitions of config entries in
core
module are in several files separately. We should move them intointernal/config
to be easy to manage.How was this patch tested?
Existing tests.