[SPARK-25927][SQL] Fix number of partitions returned by outputPartitioning #22929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @hvanhovell |
|
Test build #98392 has finished for PR 22929 at commit
|
|
Test build #98393 has finished for PR 22929 at commit
|
|
Test build #98400 has finished for PR 22929 at commit
|
# Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala # sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala # sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvalPythonExec.scala # sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/WriteToContinuousDataSourceExec.scala
|
Test build #98677 has finished for PR 22929 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to make the
outputPartitioning()method abstract inSparkPlanand implement it in child nodes to return actual number of partitions. Currently the method returns 0 partitions by default which is wrong in most cases.How was this patch tested?
It was tested by SqlQueryTestSuite.