-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-25972][PYTHON] Missed JSON options in streaming.py #22973
Conversation
@HyukjinKwon Thank you for pointing out the missed options. Please, have a look at the PR. |
Oh, let's name it |
Test build #98589 has finished for PR 22973 at commit
|
I see some of on-going PR have tag |
Yea .. actually that's documented in https://spark.apache.org/contributing.html . Strictly it should be
I tried to be clear for myself so I took a look before but .. not a big deal at all :D. |
Test build #98639 has finished for PR 22973 at commit
|
Test build #98695 has finished for PR 22973 at commit
|
Merged to master. |
## What changes were proposed in this pull request? Added JSON options for `json()` in streaming.py that are presented in the similar method in readwriter.py. In particular, missed options are `dropFieldIfAllNull` and `encoding`. Closes apache#22973 from MaxGekk/streaming-missed-options. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
What changes were proposed in this pull request?
Added JSON options for
json()
in streaming.py that are presented in the similar method in readwriter.py. In particular, missed options aredropFieldIfAllNull
andencoding
.