[SPARK-26055][CORE] InterfaceStability annotations should be retained at runtime #23029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Nov 14, 2018
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| package org.apache.spark.annotation; | |||
|
|
|||
| import java.lang.annotation.Documented; | |||
| import java.lang.annotation.*; | |||
There was a problem hiding this comment.
No big deal, but I think we'd usually explicitly import 3 classes.
There was a problem hiding this comment.
Actually we need to import 5 classes, that's why my IDE turned it into * automatically...
|
Test build #98810 has finished for PR 23029 at commit
|
|
retest this please |
|
Test build #98822 has finished for PR 23029 at commit
|
|
Since you're here do you want to add |
|
Test build #98854 has finished for PR 23029 at commit
|
|
thanks, merging to master! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
… at runtime ## What changes were proposed in this pull request? It's good to have annotations available at runtime, so that tools like MiMa can detect them and deal with then specially. e.g. we don't want to track compatibility for unstable classes. This PR makes `InterfaceStability` annotations to be retained at runtime, to be consistent with `Experimental` and `DeveloperApi` ## How was this patch tested? N/A Closes apache#23029 from cloud-fan/annotation. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's good to have annotations available at runtime, so that tools like MiMa can detect them and deal with then specially. e.g. we don't want to track compatibility for unstable classes.
This PR makes
InterfaceStabilityannotations to be retained at runtime, to be consistent withExperimentalandDeveloperApiHow was this patch tested?
N/A