Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-26102][SQL][TEST] Extracting common CSV/JSON functions tests #23071

Closed
wants to merge 4 commits into from
Closed

[SPARK-26102][SQL][TEST] Extracting common CSV/JSON functions tests #23071

wants to merge 4 commits into from

Conversation

MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Nov 17, 2018

What changes were proposed in this pull request?

Extracted common tests from CsvFunctionsSuite and JsonFunctionsSuite to the FunctionsTests trait.

How was this patch tested?

by CsvFunctionsSuite and JsonFunctionsSuite.

@MaxGekk
Copy link
Member Author

MaxGekk commented Nov 17, 2018

@dongjoon-hyun May I ask you to review the PR.

@SparkQA
Copy link

SparkQA commented Nov 17, 2018

Test build #98970 has finished for PR 23071 at commit 3884aa3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

I think we don't need this for now. Let's do this when more from/to_... functions are added later. The amount of codes increases actually.

@MaxGekk
Copy link
Member Author

MaxGekk commented Nov 21, 2018

Let's do this when more from/to_... functions are added later.

Sure. I am closing this.

@MaxGekk MaxGekk closed this Nov 21, 2018
@HyukjinKwon
Copy link
Member

Thank you @MaxGekk.

@MaxGekk MaxGekk deleted the common-functions-tests branch August 17, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MaxGekk @SparkQA @HyukjinKwon