Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19798][SQL] Refresh table does not have effect on other sessions than the issuing one #23074

Closed
wants to merge 1 commit into from
Closed

Conversation

gbloisi
Copy link
Contributor

@gbloisi gbloisi commented Nov 17, 2018

What changes were proposed in this pull request?

Refresh table command does not have effect on other sessions than the issuing one.

Move table relation cache from session catalog to session shared state so that different sessions can synchronize when a table is modified and refreshed.

How was this patch tested?

New test in HiveMetadataCacheSuite

…ssuing one.

Move table relation cache from session catalog to session sharedstate so that different sessions can synchronize when refresh table command is issued.
New test in HiveMetadataCacheSuite demonstrates the need.
@maropu maropu changed the title [SPARK-19798] Refresh table does not have effect on other sessions than the issuing one [SPARK-19798][SQL] Refresh table does not have effect on other sessions than the issuing one Mar 22, 2019
@maropu
Copy link
Member

maropu commented Mar 22, 2019

Could you please put a simple query to reproduce the issue this PR described in the PR description?
Is this a HMS-specific issue? Is there no problem when we use spark w/o the hive profile?

@gbloisi
Copy link
Contributor Author

gbloisi commented Mar 22, 2019

A spark shell example is provided with https://issues.apache.org/jira/browse/SPARK-19798. The provided test is put in HiveMetadataCacheSuite because there I found a very similar test to modify and show the problem, but I think it is reproducible with any data store that requires some level of refreshing in case of concurrent changes: the potentially stale data is from the cache in the sessionCatalog and this cache does not get refreshed across sessions.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@github-actions
Copy link

github-actions bot commented Jan 4, 2020

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just
a way of keeping the PR queue manageable.

If you'd like to revive this PR, please reopen it!

@github-actions github-actions bot added the Stale label Jan 4, 2020
@github-actions github-actions bot closed this Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants