[SPARK-26195][SQL] Correct exception messages in some classes #23154
Conversation
|
Can one of the admins verify this patch? |
|
Good catch. I believe other files (e.g. |
lcqzte10192193
changed the title
lcqzte10192193
changed the title
lcqzte10192193
force-pushed
the
wid-lcq-1127
branch
from
1de8146
to
75666f5
Compare
ok，I will fix them，thanks |
|
@lcqzte10192193 I am sorry for my misunderstanding The original code in |
| @@ -204,10 +204,10 @@ case class UnresolvedGenerator(name: FunctionIdentifier, children: Seq[Expressio | |||
| throw new UnsupportedOperationException(s"Cannot evaluate expression: $this") | |||
|
|
|||
| override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = | |||
| throw new UnsupportedOperationException(s"Cannot evaluate expression: $this") | |||
| throw new UnsupportedOperationException(s"Cannot generate code expression: $this") | |||
There was a problem hiding this comment.
Is it better to use generate code for expression or others rather than generate code expression?
There was a problem hiding this comment.
Yes,I fix them.
| @@ -258,7 +258,7 @@ case class GeneratorOuter(child: Generator) extends UnaryExpression with Generat | |||
| throw new UnsupportedOperationException(s"Cannot evaluate expression: $this") | |||
|
|
|||
| final override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = | |||
| throw new UnsupportedOperationException(s"Cannot evaluate expression: $this") | |||
| throw new UnsupportedOperationException(s"Cannot generate code expression: $this") | |||
| @@ -510,42 +510,42 @@ public void readIntegers(int total, WritableColumnVector c, int rowId) { | |||
|
|
|||
| @Override | |||
| public byte readByte() { | |||
| throw new UnsupportedOperationException("only readInts is valid."); | |||
| throw new UnsupportedOperationException("only readByte is valid."); | |||
There was a problem hiding this comment.
These exception messages seem to be correct ?
lcqzte10192193
force-pushed
the
wid-lcq-1127
branch
from
75666f5
to
a7eb915
Compare
|
LGTM,thanks |
|
LGTM cc @cloud-fan |
|
thanks, merging to master! |
## What changes were proposed in this pull request? UnsupportedOperationException messages are not the same with method name.This PR correct these messages. ## How was this patch tested? NA Closes apache#23154 from lcqzte10192193/wid-lcq-1127. Authored-by: lichaoqun <li.chaoqun@zte.com.cn> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
What changes were proposed in this pull request?
UnsupportedOperationException messages are not the same with method name.This PR correct these messages.
How was this patch tested?
NA