[SPARK-26232][Build][test-maven] Remove unused dependency to Netty3 #23188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #99511 has finished for PR 23188 at commit
|
attilapiros
changed the title
|
Jenkins, retest this please |
|
Test build #99512 has finished for PR 23188 at commit
|
|
I am closing this issue as I see one of the third party tool uses Netty3. So as a transitive dependency Netty3 is really needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removing dependency to Netty3 as it is unused.
The reason it is not collide with Netty4 is they are using different package names:
Netty3: org.jboss.netty.*
Netty4: io.netty.*
How was this patch tested?
Maven build.