[SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exception bound unit test #23226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Dec 5, 2018
|
|
||
| try { | ||
| new BytesToBytesMap( | ||
| taskMemoryManager, |
There was a problem hiding this comment.
Let's keep the indentation consistent. BTW this isn't a minor as well. It needs a JIRA.
There was a problem hiding this comment.
ok,I will correct this indentation and propose JIRA.
wangjiaochun
force-pushed
the
BytesToBytesMapSuite
branch
from
dd3b0e5
to
3a0fb2a
Compare
wangjiaochun
changed the title
HyukjinKwon
reviewed
Dec 7, 2018
| new BytesToBytesMap( | ||
| taskMemoryManager, | ||
| 1, | ||
| TaskMemoryManager.MAXIMUM_PAGE_SIZE_BYTES+1); |
|
Test build #4457 has finished for PR 23226 at commit
|
Add max page size exception bounds checking test resolve conversation
wangjiaochun
force-pushed
the
BytesToBytesMapSuite
branch
from
3a0fb2a
to
486f2b5
Compare
|
retest this please |
|
Test build #4462 has finished for PR 23226 at commit
|
HyukjinKwon
approved these changes
Dec 10, 2018
|
Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…test ## What changes were proposed in this pull request? Add MAXIMUM_PAGE_SIZE_BYTES Exception test ## How was this patch tested? Existing tests (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. Closes apache#23226 from wangjiaochun/BytesToBytesMapSuite. Authored-by: 10087686 <wang.jiaochun@zte.com.cn> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add MAXIMUM_PAGE_SIZE_BYTES Exception test
How was this patch tested?
Existing tests
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.