Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-26271][FOLLOW-UP][SQL] remove unuse object SparkPlan #23227

Closed
wants to merge 1 commit into from
Closed

[SPARK-26271][FOLLOW-UP][SQL] remove unuse object SparkPlan #23227

wants to merge 1 commit into from

Conversation

heary-cao
Copy link
Contributor

What changes were proposed in this pull request?

this code come from PR: #11190,
but this code has never been used, only since PR: #14548,
Let's continue fix it. thanks.

How was this patch tested?

N / A

@heary-cao
Copy link
Contributor Author

cc @cloud-fan, @gatorsmile, @hvanhovell ,@davies

@heary-cao heary-cao changed the title [SPARK-16958][FOLLOW-UP][SQL] remove unuse object SparkPlan [SPARK-26271][FOLLOW-UP][SQL] remove unuse object SparkPlan Dec 5, 2018
@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Dec 5, 2018

Test build #99704 has finished for PR 23227 at commit 5cb416d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Dec 5, 2018

Test build #99702 has finished for PR 23227 at commit 5cb416d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 5, 2018

Test build #99719 has finished for PR 23227 at commit 5cb416d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@heary-cao
Copy link
Contributor Author

retest this please

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@asfgit asfgit closed this in 7bb1dab Dec 5, 2018
@heary-cao
Copy link
Contributor Author

thanks,@cloud-fan,@HyukjinKwon

@SparkQA
Copy link

SparkQA commented Dec 5, 2018

Test build #99731 has finished for PR 23227 at commit 5cb416d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
@heary-cao @jackylee-ch
[SPARK-26271][FOLLOW-UP][SQL] remove unuse object SparkPlan
c932a07 
## What changes were proposed in this pull request?

this code come from PR: apache#11190,
but this code has never been used, only since  PR: apache#14548,
Let's continue fix it. thanks.

## How was this patch tested?

N / A

Closes apache#23227 from heary-cao/unuseSparkPlan.

Authored-by: caoxuewen <cao.xuewen@zte.com.cn>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloud-fan cloud-fan cloud-fan approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@heary-cao @HyukjinKwon @SparkQA @cloud-fan