[SPARK-19827][R][FOLLOWUP] spark.ml R API for PIC #23292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srowen Sorry for the problems and thanks for the PR. I am actually working on the follow up PR, but I wasn't fast enough. |
huaxingao
reviewed
Dec 11, 2018
R/pkg/R/mllib_clustering.R
Outdated
| @@ -621,38 +621,35 @@ setMethod("write.ml", signature(object = "LDAModel", path = "character"), | |||
| #' | |||
| #' A scalable graph clustering algorithm. Users can call \code{spark.assignClusters} to | |||
| #' return a cluster assignment for each input vertex. | |||
| #' | |||
| # Run the PIC algorithm and returns a cluster assignment for each input vertex. | |||
There was a problem hiding this comment.
sorry I missed the '. should be #'
huaxingao
reviewed
Dec 11, 2018
| #' \code{sequence: ArrayType(ArrayType(T))} (T is the item type) | ||
| #' \code{freq: Long} | ||
| #' \code{sequence: ArrayType(ArrayType(T))}, \code{freq: integer} | ||
| #' where T is the item type |
There was a problem hiding this comment.
I know there is a problem here too. But the one that needs to get fixed is in line 637 in R/pkg/R/mllib_clustering.R.
I guess I will have a separate follow up PR to fix the mllib_fpm.R problem. Sorry for the mess.
There was a problem hiding this comment.
Yeah I wanted to fix both here while we're at it.
|
Test build #99988 has finished for PR 23292 at commit
|
|
Test build #99990 has finished for PR 23292 at commit
|
HyukjinKwon
approved these changes
Dec 12, 2018
felixcheung
approved these changes
Dec 12, 2018
| #' \code{sequence: ArrayType(ArrayType(T))} (T is the item type) | ||
| #' \code{freq: Long} | ||
| #' \code{sequence: ArrayType(ArrayType(T))}, \code{freq: integer} | ||
| #' where T is the item type |
|
Merged to master |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
## What changes were proposed in this pull request? Follow up style fixes to PIC in R; see apache#23072 ## How was this patch tested? Existing tests. Closes apache#23292 from srowen/SPARK-19827.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Follow up style fixes to PIC in R; see apache#23072 ## How was this patch tested? Existing tests. Closes apache#23292 from srowen/SPARK-19827.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow up style fixes to PIC in R; see #23072
How was this patch tested?
Existing tests.