New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-26409][SQL][TESTS] SQLConf should be serializable in test sessions #23352
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,4 +27,9 @@ class SerializationSuite extends SparkFunSuite with SharedSQLContext { | |
val spark = SparkSession.builder.getOrCreate() | ||
new JavaSerializer(new SparkConf()).newInstance().serialize(spark.sqlContext) | ||
} | ||
|
||
test("[SPARK-26409] SQLConf should be serializable") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is following the other test case in the test suite. I can change it to either way. What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea, it should be okay as is. Honestly I want to to reformat all of them tho, it's obviously separate topic to discuss across the codebase. |
||
val spark = SparkSession.builder.getOrCreate() | ||
new JavaSerializer(new SparkConf()).newInstance().serialize(spark.sessionState.conf) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, this is touching
src/main
instead ofsrc/test
. But, no problem because it'sWithTestConf
. :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should move this trait to
src/test
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloud-fan agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried but failed.
Warning from IDE: Interface
org.apache.spark.sql.internal.WithTestConf
, referenced in fileTestHive.scala
, will not be accessible from modulespark-hive