[SPARK-26446][CORE] Add cachedExecutorIdleTimeout docs at ExecutorAllocationManager #23386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Dec 26, 2018
|
Test build #4486 has finished for PR 23386 at commit
|
|
retest this please. |
|
Test build #4487 has finished for PR 23386 at commit
|
|
Retest this please. |
|
Hi, @TopGunViper . Thank you for your first contribution! |
TopGunViper
changed the title
|
Hi, @dongjoon-hyun Thank you for your review. |
beliefer
approved these changes
Dec 28, 2018
|
Test build #100482 has finished for PR 23386 at commit
|
dongjoon-hyun
approved these changes
Dec 28, 2018
| @@ -57,7 +57,8 @@ import org.apache.spark.util.{Clock, SystemClock, ThreadUtils, Utils} | |||
| * a long time to ramp up under heavy workloads. | |||
| * | |||
| * The remove policy is simpler: If an executor has been idle for K seconds, meaning it has not | |||
| * been scheduled to run any tasks, then it is removed. | |||
| * been scheduled to run any tasks, then it is removed. Note that if an executor caching any data | |||
| * blocks will be removed until it has been idle for more then L seconds. | |||
There was a problem hiding this comment.
Ur, I know the meaning, but this sentence itself looks unclear to me; if, until? Could you make this simpler?
Note that if an executor caching any data blocks will be removed until it has been idle for more then L seconds.
There was a problem hiding this comment.
How about remove if and change until to if or once ?
Ngone51
reviewed
Dec 28, 2018
TopGunViper
force-pushed
the
SPARK-26446
branch
from
dec0449
to
e887d2b
Compare
dongjoon-hyun
approved these changes
Dec 28, 2018
|
Merged to master. Thank you, @TopGunViper , @srowen , @Ngone51 . |
|
Thanks a lot for review, @dongjoon-hyun @Ngone51 @srowen |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
…ocationManager ## What changes were proposed in this pull request? Add docs to describe how remove policy act while considering the property `spark.dynamicAllocation.cachedExecutorIdleTimeout` in ExecutorAllocationManager ## How was this patch tested? comment-only PR. Closes apache#23386 from TopGunViper/SPARK-26446. Authored-by: wuqingxin <wuqingxin@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…ocationManager ## What changes were proposed in this pull request? Add docs to describe how remove policy act while considering the property `spark.dynamicAllocation.cachedExecutorIdleTimeout` in ExecutorAllocationManager ## How was this patch tested? comment-only PR. Closes apache#23386 from TopGunViper/SPARK-26446. Authored-by: wuqingxin <wuqingxin@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add docs to describe how remove policy act while considering the property
spark.dynamicAllocation.cachedExecutorIdleTimeoutin ExecutorAllocationManagerHow was this patch tested?
comment-only PR.