Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-26306][TEST][BUILD] More memory to de-flake SorterSuite #23425

Closed
wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Jan 2, 2019

What changes were proposed in this pull request?

Increase test memory to avoid OOM in TimSort-related tests.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Jan 2, 2019

Test build #100634 has finished for PR 23425 at commit 1aa7ad7.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Jan 2, 2019

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 2, 2019

Test build #100637 has finished for PR 23425 at commit 1aa7ad7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Thank you for making this PR. I know that we are very conservative in this area, but I'm +1 for this PR.

@rxin and @aarondav . Since SPARK-26306 is related to SPARK-5984, could you give us some advice for this PR?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@srowen
Copy link
Member Author

srowen commented Jan 4, 2019

Merged to master

@srowen srowen closed this Jan 4, 2019
@srowen srowen deleted the SPARK-26306 branch January 4, 2019 21:36
srowen added a commit that referenced this pull request Jan 4, 2019
## What changes were proposed in this pull request?

Increase test memory to avoid OOM in TimSort-related tests.

## How was this patch tested?

Existing tests.

Closes #23425 from srowen/SPARK-26306.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
@dongjoon-hyun
Copy link
Member

It's great. Thank you, @srowen !

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

Increase test memory to avoid OOM in TimSort-related tests.

## How was this patch tested?

Existing tests.

Closes apache#23425 from srowen/SPARK-26306.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants