[SPARK-26584][SQL] Remove spark.sql.orc.copyBatchToSpark internal conf
#23503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan , @viirya , @gengliangwang |
cloud-fan
approved these changes
Jan 10, 2019
|
Thank you for review and approval, @cloud-fan . |
HyukjinKwon
approved these changes
Jan 10, 2019
viirya
reviewed
Jan 10, 2019
| @@ -86,12 +85,8 @@ | |||
| // The memory mode of the columnarBatch | |||
| private final MemoryMode MEMORY_MODE; | |||
viirya
approved these changes
Jan 10, 2019
|
Thank you, @HyukjinKwon and @viirya . |
|
Test build #100998 has finished for PR 23503 at commit
|
|
Test build #101004 has finished for PR 23503 at commit
|
|
retest this please. |
|
Thanks, @viirya . |
|
+1, LGTM |
|
Test build #101009 has finished for PR 23503 at commit
|
|
Thank you, @gengliangwang . |
|
Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR aims to remove internal ORC configuration to simplify the code path for Spark 3.0.0. This removes the configuration `spark.sql.orc.copyBatchToSpark` and related ORC codes including tests and benchmarks. ## How was this patch tested? Pass the Jenkins with the reduced test coverage. Closes apache#23503 from dongjoon-hyun/SPARK-26584. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove internal ORC configuration to simplify the code path for Spark 3.0.0. This removes the configuration
spark.sql.orc.copyBatchToSparkand related ORC codes including tests and benchmarks.How was this patch tested?
Pass the Jenkins with the reduced test coverage.