-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-26466][CORE] Use ConfigEntry for hardcoded configs for submit categories. #23532
Conversation
Test build #101151 has finished for PR 23532 at commit
|
Ran compilation in my machine and passed.
|
Test build #101152 has finished for PR 23532 at commit
|
spark.conf.set("spark.kryoserializer.buffer.max", "50b") | ||
|
||
// this is needed to set configurations which are also defined to SparkConf | ||
spark.conf.set(SET_COMMAND_REJECTS_SPARK_CORE_CONFS.key, "false") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to set this to false
because by default it doesn't allow setting configuration which is defined in SparkConf. I'm not fully sure which one is right to do: 1) make the change as I just did 2) don't add spark.kryoserializer.buffer
and spark.kryoserializer.buffer.max
to Kryo.
Test build #101174 has finished for PR 23532 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good @HeartSaVioR ; could you rebase?
Following are addressed: * spark.kryo * spark.kryoserializer * spark.serializer * spark.jars * spark.files * spark.submit * spark.deploy * spark.worker
c263104
to
b00669d
Compare
@srowen Thanks for reviewing! I've just rebased. |
Test build #101323 has finished for PR 23532 at commit
|
Merged to master |
Thanks for reviewing and merging, @srowen ! |
…categories. ## What changes were proposed in this pull request? The PR makes hardcoded configs below to use `ConfigEntry`. * spark.kryo * spark.kryoserializer * spark.serializer * spark.jars * spark.files * spark.submit * spark.deploy * spark.worker This patch doesn't change configs which are not relevant to SparkConf (e.g. system properties). ## How was this patch tested? Existing tests. Closes apache#23532 from HeartSaVioR/SPARK-26466-v2. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
What changes were proposed in this pull request?
The PR makes hardcoded configs below to use
ConfigEntry
.This patch doesn't change configs which are not relevant to SparkConf (e.g. system properties).
How was this patch tested?
Existing tests.