[SPARK-26613][SQL] Add another rename table grammar for spark sql #23535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Is it standard SQL or something Hive does? otherwise I don't think we'd generally add it. |
gatorsmile
reviewed
Jan 14, 2019
| @@ -105,6 +105,7 @@ statement | |||
| ADD COLUMNS '(' columns=colTypeList ')' #addTableColumns | |||
| | ALTER (TABLE | VIEW) from=tableIdentifier | |||
| RENAME TO to=tableIdentifier #renameTable | |||
| | RENAME (TABLE | VIEW) from=tableIdentifier TO to=tableIdentifier #renameTable | |||
There was a problem hiding this comment.
Thanks for your contribution! I know, MySQL has both this syntax support and ALTER TABLE ... RENAME...
In the current stage, we are not randomly adding more syntax to Spark SQL for avoiding extra complexity. In the future, we might support different dialects.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current version of spark sql contains a rename grammar,like:
alter table nameA rename to nameBoralter view nameA rename to nameB.Many database(e.g. mysql,oracle.) provide another grammar,like:
rename table nameA to nameB.I thought maybe spark sql could consider the compatibility.
How was this patch tested?
This pr have a test case as follows:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scalasql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scalasql/core/src/test/scala/org/apache/spark/sql/sources/PathOptionSuite.scalasql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala