[SPARK-26662][CORE] Dispose off-heap memory when MemoryStore is cleared #23585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I don't know this code well, but it looks reasonable to me. I suppose the only drawback is the extra work to dispose these upfront? but seems like good hygiene. |
|
Yeah, in my new test, this may cost extra time that can not be ignored. I'll close this PR. Thanks for review. @srowen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If buffer in
MemoryStore'sSerializedMemoryEntryis allocated off-heap, currentclear()action doesn't dispose them. These off-heap memory, though, will be freed when process ends, but for application that need to stop and restartSparkContextserveral times, this may cause some kind of off-heap memory leak.This PR try to dispose off-heap memory by itself when clearing
MemoryStore.How was this patch tested?
Tested manually by running code written myself, while observing system resources monitor to verify off-heap memory allocation and free behavior.
I have tried to add a unit test, but it's hard to find a way counting off-heap memory allocated by Unsafe API.