[SPARK-26649][SS] Add DSv2 noop sink #23631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #101596 has finished for PR 23631 at commit
|
dongjoon-hyun
changed the title
|
Looks clean and reasonable to me. |
|
Could you also add a simple test to make sure a query can be restarted if a checkpoint location is provided? Otherwise LGTM. |
MaxGekk
reviewed
Jan 23, 2019
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/noop/NoopDataSource.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/noop/NoopStreamSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/noop/NoopStreamSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #101635 has finished for PR 23631 at commit
|
|
Test build #101636 has finished for PR 23631 at commit
|
|
Test build #101649 has finished for PR 23631 at commit
|
dongjoon-hyun
approved these changes
Jan 25, 2019
|
+1, LGTM. Merged to master. |
|
Thank you, @gaborgsomogyi , @zsxwing , @MaxGekk , @HeartSaVioR . |
|
Thank you guys! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Noop data source for batch was added in [apache#23471](apache#23471). In this PR I've added the streaming part. ## How was this patch tested? Additional unit tests. Closes apache#23631 from gaborgsomogyi/SPARK-26649. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Noop data source for batch was added in #23471.
In this PR I've added the streaming part.
How was this patch tested?
Additional unit tests.