[SPARK-26710][TEST] Fix some errors in image test case #23633
Conversation
ImageSchemaSuite has some errors when running it in local laptop add
xubo245
force-pushed
the
SPARK-26710_FixTestErrorsInImage
branch
from
e08c617
to
91af3b2
Compare
xubo245
changed the title
xubo245
changed the title
|
Test build #101611 has finished for PR 23633 at commit
|
|
How did you run the test btw? it passes on my local (IDE) and Jenkins. |
|
@HyukjinKwon I git clone spark and mvn clean -DskipTests install, then run the test case, it throw exception like the jira content. My laptop is Mac. my Idea version is 2018.1.2. Please check the JIRA https://issues.apache.org/jira/browse/SPARK-26710 attachments, there are two picture which show errors. |
| @@ -17,9 +17,7 @@ | |||
|
|
|||
| package org.apache.spark.sql.execution.command | |||
|
|
|||
| import java.io.File | |||
There was a problem hiding this comment.
just unused import, I think no need raise a new PR for unused import.
|
|
||
| class ImageSchemaSuite extends SparkFunSuite with MLlibTestSparkContext { | ||
| // Single column of images named "image" | ||
| private lazy val imagePath = "../data/mllib/images/origin" | ||
| private lazy val imagePath = new File(this.getClass.getResource("/").getPath |
There was a problem hiding this comment.
This doesn't look right; looks like you're trying to fix the test rather than you're env. The tests pass when run in my IDE and pass when run in the build. I'd close this.
There was a problem hiding this comment.
The ubuntu and Mac system both have this problem. Are there any configuration except "git clone spar, mvn clean -DskipTests install, then run the test case"?
There was a problem hiding this comment.
I use Mac but looks no problem in my IDE. Jenkins looks no problem too. Can you investigate why it is?
|
Test build #101628 has finished for PR 23633 at commit
|
What changes were proposed in this pull request?
Fix test errors in image test case
(Please fill in changes proposed in this fix)
How was this patch tested?
run test case
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.