New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-26766][CORE] Remove the list of filesystems from HadoopDelegationTokenProvider.obtainDelegationTokens #23698
Conversation
…ionTokenProvider.obtainDelegationTokens
Test build #101891 has finished for PR 23698 at commit
|
Test build #101895 has finished for PR 23698 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the docs that reference the settings you're renaming.
core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
Outdated
Show resolved
Hide resolved
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
Show resolved
Hide resolved
* Config parameter deprecation * Return defaultFS all the time * get("spark.master", null)
Test build #101959 has finished for PR 23698 at commit
|
Test build #101960 has finished for PR 23698 at commit
|
core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/internal/config/package.scala
Outdated
Show resolved
Hide resolved
Still missing the doc update. |
* Doc update * Param deprecation
Yeah, left from the last commit :/ Now updated. |
Test build #101994 has finished for PR 23698 at commit
|
* Simplified hadoopFSsToAccess * Moved doc to generic area
Test build #102077 has finished for PR 23698 at commit
|
retest this please |
Test build #102082 has finished for PR 23698 at commit
|
Merging to master. |
…ionTokenProvider.obtainDelegationTokens ## What changes were proposed in this pull request? Delegation token providers interface now has a parameter `fileSystems` but this is needed only for `HadoopFSDelegationTokenProvider`. In this PR I've addressed this issue in the following way: * Removed `fileSystems` parameter from `HadoopDelegationTokenProvider` * Moved `YarnSparkHadoopUtil.hadoopFSsToAccess` into `HadoopFSDelegationTokenProvider` * Moved `spark.yarn.stagingDir` into core * Moved `spark.yarn.access.namenodes` into core and renamed to `spark.kerberos.access.namenodes` * Moved `spark.yarn.access.hadoopFileSystems` into core and renamed to `spark.kerberos.access.hadoopFileSystems` ## How was this patch tested? Existing unit tests. Closes apache#23698 from gaborgsomogyi/SPARK-26766. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
What changes were proposed in this pull request?
Delegation token providers interface now has a parameter
fileSystems
but this is needed only forHadoopFSDelegationTokenProvider
.In this PR I've addressed this issue in the following way:
fileSystems
parameter fromHadoopDelegationTokenProvider
YarnSparkHadoopUtil.hadoopFSsToAccess
intoHadoopFSDelegationTokenProvider
spark.yarn.stagingDir
into corespark.yarn.access.namenodes
into core and renamed tospark.kerberos.access.namenodes
spark.yarn.access.hadoopFileSystems
into core and renamed tospark.kerberos.access.hadoopFileSystems
How was this patch tested?
Existing unit tests.