[SPARK-26861][SQL] deprecate typed sum/count/average #23763
Closed
+89
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea, deprecating way works to me. +1. |
|
Test build #102252 has finished for PR 23763 at commit
|
HyukjinKwon
reviewed
Feb 12, 2019
| } | ||
| // scalastyle:on println | ||
|
|
||
| class TypedSum[IN](val f: IN => Long) extends Aggregator[IN, Long, Long] { |
There was a problem hiding this comment.
Yup, +1 to have an example somewhere like this since Aggregator seems to be still an API, it looks better to let users know how to use it. If we go ahead with getting these out, the current PR looks quite good and conservative.
|
retest this please |
|
Test build #102259 has finished for PR 23763 at commit
|
HyukjinKwon
approved these changes
Feb 13, 2019
gatorsmile
reviewed
Feb 15, 2019
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? These builtin typed aggregate functions are not very useful: 1. users can just call the untyped ones and turn the resulting dataframe to a dataset. It has better performance. 2. the typed aggregate functions have subtle different behaviors regarding empty input. I think we should get rid of these builtin typed agg functions and suggest users to use the untyped ones. However, these functions are still useful as a demo of the `Aggregator` API, so I copied them to the example module. ## How was this patch tested? N/A Closes apache#23763 from cloud-fan/example. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
These builtin typed aggregate functions are not very useful:
I think we should get rid of these builtin typed agg functions and suggest users to use the untyped ones.
However, these functions are still useful as a demo of the
AggregatorAPI, so I copied them to the example module.How was this patch tested?
N/A