[SPARK-26882] Check the Kubernetes integration tests scalatyle

[holdenk]

What changes were proposed in this pull request?

Add the kubernetes integration tests to the scalastyle profiles.

How was this patch tested?

Run ./dev/scalastyle with a bad change manually

Follow on work

See SPARK-26898 to add scalastyle for k8s integration to the CI

[holdenk]

The WIP part is to resolve any scala style issues that pop up during CI.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/7955/

[SparkQA]

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/7955/

[SparkQA]

Test build #102365 has finished for PR 23792 at commit a159aff.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[felixcheung]

I recall the way this is setup right now, buildin the profile will try to execute the tests?

[holdenk]

I mean we aren't building the profile per-se, we're only evaluating scalastyle test:scalastyle on it, but let me double check locally.

[holdenk]

Running ./dev/scalastyle after this change locally does not trigger the k8s integration tests

[vanzin]

Hmm, I wonder how style errors were not triggered here? Maybe the PR builders don't use that script?

I had to make a style change in Minikube.scala as part of #23793, because sbt complains about it.

[holdenk]

@vanzin I think the PR builders do a different style check yeah, I'll dig into that as well and keep this as WIP.

[holdenk]

@vanzin Looking at Jenkins it looks like we depend on the scala-style-during-compile configuration now days for CI and the k8s integration tests have a skip flag turned on for that.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/7982/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/7982/

[holdenk]

Ok I think fixing this in CI is probably better done in a separate PR, I've created a follow up issue SPARK-26898 , I think someone who is more familiar with how the K8s integration build is set up will make more progress on that.

[SparkQA]

Test build #102402 has finished for PR 23792 at commit c50f10d.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

Merging to master. Although I really wish some build would fail if there was a style issue, preferably a PR build.