-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-26945][PYTHON][SS][TESTS] Fix flaky test_*_await_termination in PySpark SS tests #23870
Conversation
Test build #102633 has finished for PR 23870 at commit
|
Test build #102634 has finished for PR 23870 at commit
|
Test build #102637 has finished for PR 23870 at commit
|
Test build #102636 has finished for PR 23870 at commit
|
Test build #102639 has finished for PR 23870 at commit
|
Test build #102640 has finished for PR 23870 at commit
|
Test build #102641 has finished for PR 23870 at commit
|
Test build #102643 has finished for PR 23870 at commit
|
Test build #102645 has finished for PR 23870 at commit
|
Test build #102646 has finished for PR 23870 at commit
|
Test build #102650 has finished for PR 23870 at commit
|
Test build #102654 has finished for PR 23870 at commit
|
Test build #102659 has finished for PR 23870 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The __init.py__
thing was just to make sure the right tests get triggered? Looks good minus that.
Test build #102661 has finished for PR 23870 at commit
|
Yup .. let me run this few more times to be 100% sure. Looks it wasn't that flaky much so it's kind of difficult to be sure. |
Test build #102668 has finished for PR 23870 at commit
|
Test build #102670 has finished for PR 23870 at commit
|
Test build #102673 has finished for PR 23870 at commit
|
Test build #102675 has finished for PR 23870 at commit
|
Test build #102678 has finished for PR 23870 at commit
|
Test build #102684 has finished for PR 23870 at commit
|
right, looks fixed. I'm going to merge this one and keep fixing flaky tests. |
4061fe5
to
d0851aa
Compare
Test build #102689 has finished for PR 23870 at commit
|
Test build #102691 has finished for PR 23870 at commit
|
Merged to master. Thanks, @srowen and @felixcheung |
Thanks @HyukjinKwon |
What changes were proposed in this pull request?
This PR proposes to make sure processing all available data before stopping and delete the temp directory.
See https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102518/console
See https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102311/console
How was this patch tested?
Jenkins tests - I should run multiple times to see if there are other flaky tests + if this PR really fixes it.