Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-27034][SQL][Followup] Rename ParquetSchemaPruning to SchemaPruning #24077

Closed

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 13, 2019

What changes were proposed in this pull request?

This is a followup to #23943. This proposes to rename ParquetSchemaPruning to SchemaPruning as ParquetSchemaPruning supports both Parquet and ORC v1 now.

How was this patch tested?

Existing tests.

@viirya
Copy link
Member Author

viirya commented Mar 13, 2019

cc @dongjoon-hyun Created the followup PR to rename ParquetSchemaPruning.

@dongjoon-hyun
Copy link
Member

Thank you, @viirya !

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Pending Jenkins)

@SparkQA
Copy link

SparkQA commented Mar 13, 2019

Test build #103410 has finished for PR 24077 at commit 459b046.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Mar 13, 2019

Test build #103418 has finished for PR 24077 at commit 459b046.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@SparkQA
Copy link

SparkQA commented Mar 13, 2019

Test build #103422 has finished for PR 24077 at commit 459b046.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Mar 13, 2019

@viirya viirya deleted the nested-schema-pruning-orc-followup branch December 27, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants