Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-27034][SPARK-27123][SQL][FOLLOWUP] Update Nested Schema Pruning BM result with EC2 #24078

Closed
wants to merge 1 commit into from
Closed

[SPARK-27034][SPARK-27123][SQL][FOLLOWUP] Update Nested Schema Pruning BM result with EC2 #24078

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This is a follow up PR for #23943 in order to update the benchmark result with EC2 r3.xlarge instance.

How was this patch tested?

N/A. (Manually compare the diff)

@dongjoon-hyun
Copy link
Member Author

cc @viirya

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27034][SQL][FOLLOWUP] Update benchmark result with EC2 result [SPARK-27034][SQL][FOLLOWUP] Update Nested Schema Pruning benchmark result with EC2 Mar 13, 2019
@dongjoon-hyun
Copy link
Member Author

Thank you for review, @viirya .

@viirya
Copy link
Member

viirya commented Mar 13, 2019

Thanks for updating it. @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Mar 13, 2019

Test build #103411 has finished for PR 24078 at commit af332e6.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor

retest this please

@HyukjinKwon
Copy link
Member

Sorry if I missed something, @dongjoon-hyun. Does this PR simply updates the results against EC2 or updates outdated results? I think it's also fine to use Mac if it's the former.

In any event, I guess it's fine to go ahead but wanted to be sure if there'a any reason for it.

@SparkQA
Copy link

SparkQA commented Mar 13, 2019

Test build #103417 has finished for PR 24078 at commit af332e6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Mar 13, 2019 •
edited
Loading

@HyukjinKwon . This is an update to make the baseline for the other PR.

Also, there is another PR which landed on the master at the same time

dongjoon-hyun
dongjoon-hyun commented Mar 13, 2019
View reviewed changes
sql/core/benchmarks/ParquetNestedSchemaPruningBenchmark-results.txt
Top-level column 263 315 36 3.8 263.2 1.0X
Nested column 2111 2622 613 0.5 2111.1 0.1X
Top-level column 434 508 108 2.3 434.3 1.0X
Nested column 625 647 23 1.6 624.8 0.7X
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the result of #24049 .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27034][SQL][FOLLOWUP] Update Nested Schema Pruning benchmark result with EC2 [SPARK-27034][SPARK-27123][SQL][FOLLOWUP] Update Nested Schema Pruning BM result with EC2 Mar 13, 2019
@dongjoon-hyun
Copy link
Member Author

Hi, @dbtsai . Could you review this please when you have some time?

@dbtsai
Copy link
Member

dbtsai commented Mar 13, 2019

LGTM. Thanks!

@dbtsai dbtsai closed this Mar 13, 2019
dbtsai pushed a commit that referenced this pull request Mar 13, 2019
@dongjoon-hyun @dbtsai
[SPARK-27034][SPARK-27123][SQL][FOLLOWUP] Update Nested Schema Prunin…
3221bf4 
…g BM result with EC2

## What changes were proposed in this pull request?

This is a follow up PR for #23943 in order to update the benchmark result with EC2 `r3.xlarge` instance.

## How was this patch tested?

N/A. (Manually compare the diff)

Closes #24078 from dongjoon-hyun/SPARK-27034.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: DB Tsai <d_tsai@apple.com>
@dongjoon-hyun
Copy link
Member Author

Thank you so much, @dbtsai , @viirya , @HyukjinKwon , @dilipbiswal !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-27034 branch March 13, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@dongjoon-hyun @viirya @SparkQA @dilipbiswal @HyukjinKwon @dbtsai