[SPARK-27384][SQL] File source V2: Prune unnecessary partition columns #24296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #104276 has finished for PR 24296 at commit
|
|
retest this please. |
|
Test build #104278 has finished for PR 24296 at commit
|
|
The test failures should be fixed after #24284 is merged. |
gengliangwang
force-pushed
the
prunePartitionValue
branch
from
88ce4fc
to
d16dbab
Compare
cloud-fan
reviewed
Apr 5, 2019
| @@ -40,7 +45,23 @@ abstract class FileScan( | |||
| protected def partitions: Seq[FilePartition] = { | |||
| val selectedPartitions = fileIndex.listFiles(Seq.empty, Seq.empty) | |||
| val maxSplitBytes = FilePartition.maxSplitBytes(sparkSession, selectedPartitions) | |||
| val partitionAttributes = fileIndex.partitionSchema.toAttributes | |||
| val attributeMap = partitionAttributes.map(a => getAttributeName(a) -> a).toMap | |||
| val readPartitionAttributes = readPartitionSchema.toAttributes.map { readAttr => | |||
There was a problem hiding this comment.
we should not create an attribute and just use its name. This can be
readPartitionSchema.map { readField =>
attributeMap.get(normalize(readField.name)).getOrElse ...
}
cloud-fan
reviewed
Apr 5, 2019
| @@ -52,24 +52,24 @@ import org.apache.spark.util.SerializableConfiguration | |||
| case class OrcPartitionReaderFactory( | |||
| sqlConf: SQLConf, | |||
| broadcastedConf: Broadcast[SerializableConfiguration], | |||
| resultSchema: StructType, | |||
There was a problem hiding this comment.
let's update the parameter doc in the classdoc.
|
Test build #104312 has finished for PR 24296 at commit
|
|
retest this please. |
cloud-fan
reviewed
Apr 5, 2019
| StructType(fields) | ||
| } | ||
|
|
||
| // Define as method instead of value, since `requiredSchema` is mutable. |
There was a problem hiding this comment.
but we should not create a set inside loop body. How about
def createRequiredNameset ...
...
val requiredNameSet = createRequiredNameset..
val fields = partitionSchema.fields.filter { field => ... }
|
LGTM except one comment |
|
Test build #104313 has finished for PR 24296 at commit
|
|
Test build #104317 has finished for PR 24296 at commit
|
|
Test build #104318 has finished for PR 24296 at commit
|
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When scanning file sources, we can prune unnecessary partition columns on constructing input partitions, so that:
How was this patch tested?
Existing unit tests.