New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-27831][SQL][TEST][test-hadoop3.2] Move Hive test jars to maven dependency #24695
Conversation
Test build #105756 has finished for PR 24695 at commit
|
retest this please |
Test build #105759 has finished for PR 24695 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. This looks much better to me. Merged to master.
Thank you for guide, @felixcheung . Thank you for the patch, @wangyum !
@wangyum I'm seeing failures from the master build from about the time this was committed, like:
Do you think it could be related? |
Thank you for heading up. Maven seems to work differently. Let me revert this. |
I'm not sure if it's the problem, just looked potentially related and happened right before the failures started happening. We might investigate a little bit to see if there's an easy fix-forward, or whether it's the issue |
We had better recover the Jenkins first. Then, we can have enough time to get a correct patch. Sorry for the troubles in maven build~ |
Add <!-- Explicit listing hive-hcatalog-core. Otherwise the maven build fails. -->
<dependency>
<groupId>${hive.group}.hcatalog</groupId>
<artifactId>hive-hcatalog-core</artifactId>
</dependency> It can find hive-hcatalog-core:jar after adding
|
@wangyum if that fixes forward, let's try that instead of a revert. |
Thank you, @wangyum. Yes, please make a PR with that approach, @wangyum . At this time, let's test with all combinations. Last time, we tested SBT(hadoop-2.7/hadoop-3.2) only. @srowen . Unfortunately, this patch is already reverted from the master, and it's verified in another PR (here, #24745 (review)) to pass the Maven. The last Jenkins passed the Hive UT but failed at some YARN UTs. I guess the next run will pass. |
What changes were proposed in this pull request?
This pr moves Hive test jars(
hive-contrib-0.13.1.jar
,hive-hcatalog-core-0.13.1.jar
,hive-contrib-2.3.5.jar
andhive-hcatalog-core-2.3.5.jar
) to maven dependency.How was this patch tested?
Existing test