[SPARK-28115][CORE][TEST] Fix flaky test: SparkContextSuite.test resource scheduling under local-cluster mode #24917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #106693 has finished for PR 24917 at commit
|
|
Thank you so much for quick fix, @jiangxb1987 ! |
There was a problem hiding this comment.
This test suite also fails with the following. I updated the JIRA issue. Could you fix that, too?
org.scalatest.exceptions.TestFailedException: Array("0", "0", "1", "1", "1", "2", "2", "2", "2") did not equal List("0", "0", "0", "1", "1", "1", "2", "2", "2")
at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528)
at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:527)
at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1560)
at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:501)
at org.apache.spark.SparkContextSuite.$anonfun$new$93(SparkContextSuite.scala:894)
|
cc @gatorsmile |
|
LGTM. Merged into master. @dongjoon-hyun the test you linked is fixed in this PR. |
|
Cool. Thanks for the confirmation, @mengxr . |
kiku-jw
pushed a commit
to kiku-jw/spark
that referenced
this pull request
Jun 26, 2019
…urce scheduling under local-cluster mode ## What changes were proposed in this pull request? The test `SparkContextSuite.test resource scheduling under local-cluster mode` has been flaky, because it expects the size of `sc.statusTracker.getExecutorInfos` be the same as the number of executors, while the returned list contains both the driver and executors. ## How was this patch tested? Updated existing tests. Closes apache#24917 from jiangxb1987/getExecutorInfos. Authored-by: Xingbo Jiang <xingbo.jiang@databricks.com> Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The test
SparkContextSuite.test resource scheduling under local-cluster modehas been flaky, because it expects the size ofsc.statusTracker.getExecutorInfosbe the same as the number of executors, while the returned list contains both the driver and executors.How was this patch tested?
Updated existing tests.