[SPARK-28002][SQL][FOLLOWUP] Fix duplicate CTE error message and add more test cases #24949
Conversation
|
ok to test |
|
add to whitelist |
|
Test build #106829 has finished for PR 24949 at commit
|
| WITH t() AS (SELECT 1) | ||
| SELECT * FROM t; | ||
|
|
||
| -- CTE with duplicate name is not allowed |
There was a problem hiding this comment.
According to @gatorsmile 's comment, could you add a t(x, x) test case, too?
Duplicate names within a single CTE definition are not allowed.
There was a problem hiding this comment.
We need to capture the duplicate names earlier and issue a better error message
There was a problem hiding this comment.
Hmm, I added the t(x, x) case, but it is allowed, and I think it is right to be allowed.
I thought @gatorsmile referred to the
WITH
t(x) AS (SELECT 1),
t(x) AS (SELECT 2)
SELECT * FROM t;
case, which is not.
@gatorsmile we capture the duplicate CTE name during parsing, I fixed the error message though.
If I got something wrong please let me know.
There was a problem hiding this comment.
@gatorsmile, @dongjoon-hyun do you think the PR is ok now?
|
Test build #106845 has finished for PR 24949 at commit
|
|
Test build #106871 has finished for PR 24949 at commit
|
|
retest this please |
|
Test build #106875 has finished for PR 24949 at commit
|
|
@gatorsmile, @dongjoon-hyun is there anything I can add to this PR? |
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Show resolved
Hide resolved
| -- !query 10 output | ||
| org.apache.spark.sql.catalyst.parser.ParseException | ||
|
|
||
| no viable alternative at input 'WITH t()'(line 1, pos 7) |
There was a problem hiding this comment.
Do you think we can have a more meaningful message?
There was a problem hiding this comment.
I think this standard message comes from antlr when the query doesn't fit to the .g4 definition. I'm not sure if it can be fixed.
peter-toth
changed the title
peter-toth
changed the title
peter-toth
force-pushed
the
SPARK-28002-follow-up
branch
from
8fbae02
to
0c39fb2
Compare
|
Test build #107277 has finished for PR 24949 at commit
|
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you, @peter-toth , @gatorsmile , @HyukjinKwon .
|
Thanks for the review @dongjoon-hyun, @HyukjinKwon, @gatorsmile! |
What changes were proposed in this pull request?
This PR adds some more WITH test cases as a follow-up to #24842
How was this patch tested?
Add new UTs.