-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28158][SQL] Hive UDFs supports UDT type #24961
Conversation
Test build #106870 has finished for PR 24961 at commit
|
retest this please. |
Test build #106882 has finished for PR 24961 at commit
|
@cloud-fan Could you please help to review? |
How do you handle these type data in Hive UDFs? |
@maropu For example, the internal sql type of |
But, the UDF works in Spark and not in Hive, right? I'm not sure that this is a right approach... |
@maropu I dont test the UDF in Hive, but I think it will work as it is a Hive UDF definition. |
Can we add an end-to-end test to show the value of this patch? |
Test build #107684 has finished for PR 24961 at commit
|
Test build #107685 has finished for PR 24961 at commit
|
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveInspectorSuite.scala
Outdated
Show resolved
Hide resolved
mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala
Outdated
Show resolved
Hide resolved
mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala
Outdated
Show resolved
Hide resolved
ping @uncleGen |
let me continue to finish this pr |
12ee9d6
to
a8e2fb3
Compare
a8e2fb3
to
7138d6a
Compare
Test build #111339 has finished for PR 24961 at commit
|
Test build #111340 has finished for PR 24961 at commit
|
Test build #111338 has finished for PR 24961 at commit
|
Test build #111348 has finished for PR 24961 at commit
|
ping @HyukjinKwon @cloud-fan |
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUserDefinedTypeSuite.scala
Outdated
Show resolved
Hide resolved
Test build #112603 has finished for PR 24961 at commit
|
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUserDefinedTypeSuite.scala
Outdated
Show resolved
Hide resolved
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUserDefinedTypeSuite.scala
Outdated
Show resolved
Hide resolved
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUserDefinedTypeSuite.scala
Outdated
Show resolved
Hide resolved
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUserDefinedTypeSuite.scala
Outdated
Show resolved
Hide resolved
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUserDefinedTypeSuite.scala
Outdated
Show resolved
Hide resolved
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUserDefinedTypeSuite.scala
Outdated
Show resolved
Hide resolved
Test build #112757 has finished for PR 24961 at commit
|
retest this please |
Test build #112762 has finished for PR 24961 at commit
|
Merged to master. |
I've submitted a follow-up PR as new test is high likely failing in recent CI builds. #26287 |
What changes were proposed in this pull request?
After this PR, we can create and register Hive UDFs to accept UDT type, like
VectorUDT
andMatrixUDT
. These UDTs are widely used in Spark machine learning.How was this patch tested?
add new ut