Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals #25018

Closed
wants to merge 8 commits into from
Closed

[SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals #25018

wants to merge 8 commits into from

Conversation

wangyum
Copy link
Member

@wangyum wangyum commented Jun 30, 2019

What changes were proposed in this pull request?

This pr port HIVE-15297 to fix spark-sql should not split semicolon within quoted string literals.

How was this patch tested?

unit tests and manual tests:
image

@SparkQA
Copy link

SparkQA commented Jun 30, 2019

Test build #107050 has finished for PR 25018 at commit 279636d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-26321][SQL] Port HIVE-15297: spark-sql should not split semicolon within quoted string literals [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals Jul 1, 2019
@wangyum wangyum mentioned this pull request Jul 19, 2019
Closed
4 tasks
@gatorsmile
Copy link
Member

Could you port the test cases from the original PR #23276

@SparkQA
Copy link

SparkQA commented Jul 20, 2019

Test build #107932 has finished for PR 25018 at commit 3e7318d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SparkSQLCLIDriverSuite extends SparkFunSuite
  • class SQLMatcher extends ArgumentMatcher[String]

@HyukjinKwon
Copy link
Member

@wangyum, if this is simply porting the fix, let's go ahead. can you resolve conflicts?

@wangyum
Merge remote-tracking branch 'upstream/master' into SPARK-26321
6bf8dc1 
# Conflicts:
#	sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
#	sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
@wangyum
Merge master
314a43e
@wangyum
Copy link
Member Author

wangyum commented Sep 18, 2019

@HyukjinKwon Done

@SparkQA
Copy link

SparkQA commented Sep 18, 2019

Test build #110920 has finished for PR 25018 at commit 314a43e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

HyukjinKwon
HyukjinKwon reviewed Oct 10, 2019
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyum, I think you can merge if you're pretty confident on this.

@wangyum
Copy link
Member Author

wangyum commented Oct 10, 2019

Thank you @HyukjinKwon I added another test case.

@SparkQA
Copy link

SparkQA commented Oct 11, 2019

Test build #111931 has finished for PR 25018 at commit f941a43.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals [SPARK-26321][SQL][test-hadoop3.2] Port HIVE-15297: Hive should not split semicolon within quoted string literals Oct 12, 2019
@wangyum
Copy link
Member Author

wangyum commented Oct 12, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Oct 12, 2019

Test build #111940 has finished for PR 25018 at commit f941a43.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-26321][SQL][test-hadoop3.2] Port HIVE-15297: Hive should not split semicolon within quoted string literals [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals Oct 13, 2019
@SparkQA
Copy link

SparkQA commented Oct 13, 2019

Test build #111990 has finished for PR 25018 at commit 48364a7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum closed this in 148cd26 Oct 13, 2019
@wangyum
Copy link
Member Author

wangyum commented Oct 13, 2019

Merged to master.

@wangyum wangyum deleted the SPARK-26321 branch October 13, 2019 05:23
@turboFei turboFei mentioned this pull request Jan 5, 2021
Closed
turboFei pushed a commit to turboFei/spark that referenced this pull request Jan 5, 2021
@wangyum @turboFei
[SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon w…
a6b529b 
…ithin quoted string literals

This pr port [HIVE-15297](https://issues.apache.org/jira/browse/HIVE-15297) to fix **spark-sql** should not split semicolon within quoted string literals.

unit tests and manual tests:
![image](https://user-images.githubusercontent.com/5399861/60395592-5666ea00-9b68-11e9-99dc-0e8ea98de32b.png)

Closes apache#25018 from wangyum/SPARK-26321.

Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Yuming Wang <wgyumg@gmail.com>
@turboFei turboFei mentioned this pull request Jan 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon left review comments

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
5 participants
@wangyum @SparkQA @gatorsmile @HyukjinKwon @dongjoon-hyun