Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28249][K8S][DOC] Update the path in the comment inside the Dockerfile #25051

Conversation

sujeshchirackkal
Copy link

What changes were proposed in this pull request?

Corrects the path given in the comment for building the docker image

How was this patch tested?

No testing done. it changes only the comment.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28249][Kubernetes]update the path in the comment inside the Dockerfile [SPARK-28249][K8S] Update the path in the comment inside the Dockerfile Jul 4, 2019
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28249][K8S] Update the path in the comment inside the Dockerfile [SPARK-28249][K8S][DOC] Update the path in the comment inside the Dockerfile Jul 4, 2019
@dongjoon-hyun
Copy link
Member

ok to test

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This PR looks invalid because the original one is consistent with the previous comment.

the docker build command should be invoked from the top level directory of the Spark distribution.

In the distribution, there is no resource-managers.

$ ls -al spark-2.4.3-bin-hadoop2.7
total 160
drwxr-xr-x   21 dhyun  staff    672 Jun  7 20:20 .
drwxr-xr-x   12 dhyun  staff    384 Jun  7 20:22 ..
-rw-r--r--    1 dhyun  staff  21316 Apr 30 22:19 LICENSE
-rw-r--r--    1 dhyun  staff  42919 Apr 30 22:19 NOTICE
drwxr-xr-x    3 dhyun  staff     96 Apr 30 22:19 R
-rw-r--r--    1 dhyun  staff   3952 Apr 30 22:19 README.md
-rw-r--r--    1 dhyun  staff    164 Apr 30 22:19 RELEASE
drwxr-xr-x   29 dhyun  staff    928 Apr 30 22:19 bin
drwxr-xr-x   11 dhyun  staff    352 Jun  9 21:01 conf
drwxr-xr-x    5 dhyun  staff    160 Apr 30 22:19 data
-rw-r--r--    1 dhyun  staff    785 Jun 14 00:32 derby.log
drwxr-xr-x    4 dhyun  staff    128 Apr 30 22:19 examples
drwxr-xr-x  228 dhyun  staff   7296 Apr 30 22:19 jars
drwxr-xr-x    4 dhyun  staff    128 Apr 30 22:19 kubernetes
drwxr-xr-x   49 dhyun  staff   1568 Apr 30 22:19 licenses
drwxr-xr-x    6 dhyun  staff    192 Jun 11 21:33 logs
drwxr-xr-x    9 dhyun  staff    288 Jun 14 00:32 metastore_db
drwxr-xr-x   19 dhyun  staff    608 Apr 30 22:19 python
drwxr-xr-x   24 dhyun  staff    768 Apr 30 22:19 sbin
drwxr-xr-x    3 dhyun  staff     96 Jun  2 14:38 spark-warehouse
drwxr-xr-x    3 dhyun  staff     96 Apr 30 22:19 yarn

@dongjoon-hyun
Copy link
Member

Could you close this PR, please?

@SparkQA
Copy link

SparkQA commented Jul 4, 2019

@SparkQA
Copy link

SparkQA commented Jul 4, 2019

Test build #107237 has finished for PR 25051 at commit cb62f3c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 4, 2019

@sujeshchirackkal sujeshchirackkal deleted the kube_dockerfile_update branch July 4, 2019 17:23
@dongjoon-hyun
Copy link
Member

Thank you for your understanding, @sujeshchirackkal .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants