-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base #25086
Conversation
cc: @HyukjinKwon |
ok to test |
Test build #107416 has finished for PR 25086 at commit
|
sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-aggregates_part2.sql
Show resolved
Hide resolved
sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-aggregates_part2.sql
Outdated
Show resolved
Hide resolved
Looks good otherwise. |
Test build #107422 has finished for PR 25086 at commit
|
-- | ||
-- | ||
-- AGGREGATES [Part 2] | ||
-- https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/aggregates.sql#L145-L350 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use REL_12_BETA2
here because BETA2 is already out and more closer to REL_12
. I guess REL_12_BETA2
will be the same with REL_12_BETA1
.
If not, please make this up-to-date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there's one more case. Let me make a small PR separately to address this comment for aggregates_part2.sql
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
Merged to master. Will make a follow right away, @dongjoon-hyun. |
Thank you, @HyukjinKwon ~ |
What changes were proposed in this pull request?
This PR adds some tests converted from
pgSQL/aggregates_part2.sql'
to test UDFs. Please see contribution guide of this umbrella ticket - SPARK-27921.Diff comparing to 'pgSQL/aggregates_part2.sql'
How was this patch tested?
Tested as guided in SPARK-27921.